Cleanup / Code review / Consolidation phase

Date

2011/05/11

What

Request from Zhechka to do an individual code review. Especially, to:

• list the inactive Business Rules (BR), Client Scripts (CS), etc.
• list what needs to be better commented / documented

What I made inactive, but did not delete

Due to the 'Assign to' functionality:

• [BR] In progress state only for group members - TO BE DELETED - DONE
• [BR] (req) In progress state only for group - TO BE DELETED - DONE
• [BR] Empty assignee on AssignmentGroup change - TO BE DELETED - DONE
• [BR] Assignment Group / Assigned To logic (incident) - TO BE DELETED - DONE
• [BR] Assignment Group / Assigned To logic (requests) - TO BE DELETED - DONE

Due to the 'Confidentiality' functionality:

• [BR] (CF) Set Confidential at insert/update - TO BE DELETED - DONE

To factorise

Rename

Business rules copied from out-of-the-box ones:

• [BR] - 'On-call Assign (Current) 2' -> rename to 'On-call Assign - CERN'
• [BR] - 'On-call Assign (Current or Next) 2' -> rename to 'On-call Assign (Current or Next) - CERN'

Update Set

20110614 SOPH Code cleanup

Issues

None known.

-- SophieLemaitre - 11-May-2011